Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete issues in bindings crate #2157

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

coolreader18
Copy link
Collaborator

Description of Changes

Fixes 2 specific issues:

  • invalid syntax (namely, at least, an incomplete if block: if foo) in a reducer body would cause autocomplete to break.
    • This is fixed by upgrading the proc-macro2 dependency.
  • No completions for methods on unique columns.
    • This is fixed by fiddling around with the bounds on the impl block for UniqueColumn. Best I can tell is that this was hitting some poorly-handled edge case in chalk, related to evaluating bounds that are too dependent on each other (?)

Expected complexity level and risk

1

Testing

  • Both cases now provide autocomplete with rust-analyzer.

@coolreader18 coolreader18 requested a review from Centril January 21, 2025 21:35
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thank you so much for figuring this out.

@coolreader18 coolreader18 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit 179993c Jan 23, 2025
8 of 9 checks passed
@coolreader18 coolreader18 deleted the noa/fix-autocomplete branch February 11, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants