-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track query and datastore cpu usage metrics #2140
Conversation
bc1fcdc
to
816f481
Compare
f493440
to
5bcf8c8
Compare
816f481
to
8a36603
Compare
5bcf8c8
to
9ede156
Compare
How does this affect the subscription benchmarks? |
9ede156
to
a776af2
Compare
@Centril the impact for these is negligible.
However once we introduce "bytes scanned" for example, I fully expect the difference will no longer be negligible. |
c33250b
to
22af59b
Compare
a776af2
to
e7f2b60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These metrics look good, though I'm curious about how we will be able to add byte-based read stats.
5ebb2c6
to
cc4f397
Compare
73988c2
to
cc46aad
Compare
4160fb1
to
0e657af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as code owner for websocket.rs . Have not checked the rest.
0e657af
to
e003202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a metric for bytes inserted is the only datastore-related metric that we still need, but that can be in a different PR.
e003202
to
7fe9162
Compare
Description of Changes
Tracks cpu usage metrics in both query and datastore. It does not track wasmtime fuel usage
API and ABI breaking changes
None
Expected complexity level and risk
3
The changes are relatively straightforward, just a lot of plumbing.
Testing
An existing query test was updated to test the query metrics. New tests were added for the datastore.