Add new crates to publish-crates.sh script
#2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
added
release-any
cloutiertyler
approved these changes
Jan 14, 2025
|
Yeah, unfortunately the We'd have to set up our own temporary package repository in order to test this comprehensively. The worst case is that we have to make further corrections next time we publish, which is the same state we're in without this PR. I'll add more context to the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We had several crates that were missing from the
publish-crates.shscript, meaning that manual intervention was required for it to run properly.API and ABI breaking changes
No code changes
Expected complexity level and risk
1
Testing
I believe this is where I added them in order to successfully publish to crates.io, but it's hard to re-test after the fact 🤷 Unfortunately the
--dry-runoption doesn't "just work" the way we'd want.We'd have to set up our own temporary package repository in order to test this comprehensively.
The worst case is that we have to make further corrections next time we publish, which is the same state we're in without this PR.