Implement the identity host call and ctx.identity() in Rust
#2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `ReducerContext::identity(&self) -> Identity`, a method which reads the module identity. It's useful e.g. so modules can assert that scheduled reducers are being called by the scheduler, rather than by a client. It's also a part of the API spec that fell by the wayside during 0.12. This PR also adds a smoketest that said method does what it's supposed to, and adds a call to it in the `rust-wasm-test` module that I used during manual testing. Still TODO: implement the same method in C# modules.
coolreader18
approved these changes
Jan 3, 2025
Yeah, I considered that, but I figure we don't care and I wanted to keep the PR simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR adds
ReducerContext::identity(&self) -> Identity, a method which reads the module identity. It's useful e.g. so modules can assert that scheduled reducers are being called by the scheduler, rather than by a client.It's also a part of the API spec that fell by the wayside during 0.12.
This PR also adds a smoketest that said method does what it's supposed to, and adds a call to it in the
rust-wasm-testmodule that I used during manual testing.Still TODO: implement the same method in C# modules.
API and ABI breaking changes
Adds a new API and a new ABI function, but doesn't break anything.
Expected complexity level and risk
1: it's easy!
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
assert_caller_identity_is_module_identityreducer ofrust-wasm-testand watched it panic with the expected log output for a client caller.