commitlog: Fix offset index truncation #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `ftruncate` implementation for the offset index writer to use the correct argument (transaction not byte offset). Add a test for it. Also change the commitlog `reset_to` method to truncate to `offset + 1`, so as to retain the `offset` in the index if it is there. This matches the semantics of `reset_to`, which keeps the given offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
ftruncateimplementation for the offset index writer to use the correct argument (transaction not byte offset). Add a test for it.Also change the commitlog
reset_tomethod to truncate tooffset + 1, so as to retain theoffsetin the index if it is there. This matches the semantics ofreset_to, which keeps the given offset.Expected complexity level and risk
1
Testing
This patch adds a test.