Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a spinner to show that wasm is compiling in spacetime generate #2057

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Use a spinner to show that wasm is compiling in spacetime generate #2057

merged 1 commit into from
Jan 7, 2025

Conversation

coolreader18
Copy link
Collaborator

@coolreader18 coolreader18 commented Dec 13, 2024 •
edited
Loading

Description of Changes

Little QOL improvement.

Expected complexity level and risk

1

Testing

I ran spacetime generate to ensure that the spinner shows up and tells the user what it's doing.

@coolreader18 coolreader18 force-pushed the noa/wasm-compilation-spinner branch from d9bb6d7 to 053b1ac Compare December 13, 2024 18:25
@bfops bfops added the release-any To be landed in any release window label Dec 30, 2024
cloutiertyler
cloutiertyler previously requested changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add to the description what you did, if anything, to test this?

bfops
bfops approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@coolreader18 coolreader18 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 2b227fe Jan 7, 2025
10 checks passed
@coolreader18 coolreader18 deleted the noa/wasm-compilation-spinner branch February 11, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfops bfops bfops approved these changes

@Centril Centril Centril approved these changes

@cloutiertyler cloutiertyler Awaiting requested review from cloutiertyler cloutiertyler is a code owner

Assignees
No one assigned
Labels
release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coolreader18 @bfops @Centril @cloutiertyler