core: Make NDV non-zero #1985
Merged
core: Make NDV non-zero #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
approved these changes
Nov 12, 2024
Centril
approved these changes
Nov 12, 2024
2 tasks
gefjon
approved these changes
Nov 13, 2024
Change `TxId::num_distinct_values` to return `Option<NonZeroU64>`. It will now return `None` if either the table doesn't exist, no index exists for the given column list, or the index is empty. Otherwise, `Some` non-zero number of distinct values is returned. Fixes a division-by-zero bug in the query row estimation.
kim
force-pushed
the
kim/fix/nonzero-ndv
branch
from
047827f to
16a7126
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
TxId::num_distinct_valuesto returnOption<NonZeroU64>.It will now return
Noneif either the table doesn't exist, no indexexists for the given column list, or the index is empty.
Otherwise,
Somenon-zero number of distinct values is returned.Fixes a division-by-zero bug in the query row estimation.
Expected complexity level and risk
1
Testing
No functional change,
estimation::index_row_estis now statically guaranteedto not panic due to division-by-zero