Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: Remove unused fsync param in benchmarks #1981

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

RReverser
Copy link
Contributor

Description of Changes

As the removed code comment said, fsync benchmarks are no longer necessary and no longer called, plus in most impls this param was entirely unused, so removing it altogether for clarity.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@RReverser RReverser requested review from kazimuth and mamcx November 11, 2024 14:05
@RReverser RReverser changed the title Ingvar/remove-unused-fsync-param NFC: Remove unused fsync param in benchmarks Nov 11, 2024
@RReverser RReverser changed the base branch from ingvar/test-bench-cs to master November 11, 2024 15:15
As the removed code comment said, fsync benchmarks are no longer necessary and no longer called, plus in most impls this param was entirely unused, so removing it altogether for clarity.
@RReverser RReverser force-pushed the ingvar/remove-unused-fsync-param branch from 9b1b05e to b96091f Compare November 11, 2024 17:20
@RReverser RReverser enabled auto-merge November 11, 2024 18:22
@RReverser RReverser added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 15b3e06 Nov 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants