Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing context for lowering #1963

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

joshua-spacetime
Copy link
Collaborator

Description of Changes

Please describe your change, mention any related tickets, and so on here.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@joshua-spacetime joshua-spacetime self-assigned this Nov 7, 2024
@joshua-spacetime joshua-spacetime force-pushed the joshua/refactor/logical-plan branch from 0cdbefe to e6f473e Compare November 8, 2024 00:47
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-spacetime joshua-spacetime force-pushed the joshua/refactor/logical-plan branch from e6f473e to 3121341 Compare November 8, 2024 17:07
@joshua-spacetime joshua-spacetime changed the title Named labels for logical field expressions Add typing context for lowering Nov 8, 2024
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Nov 8, 2024
Merged via the queue into master with commit 4c0c755 Nov 8, 2024
9 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/refactor/logical-plan branch November 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants