Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode identity correctly #1952

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Decode identity correctly #1952

merged 1 commit into from
Nov 6, 2024

Conversation

jsdt
Copy link
Contributor

@jsdt jsdt commented Nov 6, 2024 •
edited
Loading

Description of Changes

The token show command was decoding tokens in a way that required the identity field to be set. When we parse tokens from clients, we can compute the identity from the other claims. This PR fixes the token show command to do the same.

Expected complexity level and risk

1

Testing

@bfops tested this manually.

bfops
bfops approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me:

$ cargo run -- login show
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s
     Running `target/debug/spacetime login show`
You are logged in as c2002013212deb0bd4ce851bd6fc7fa4117b52b2af1d2341f3d39c16374a94b5

bfops added a commit that referenced this pull request Nov 6, 2024
@bfops
[release/v1.0.0-rc1]: Manually apply open PR #1952: Decode identity c…
3a10733 
…orrectly
@jsdt jsdt marked this pull request as ready for review November 6, 2024 18:52
@jsdt jsdt requested a review from cloutiertyler as a code owner November 6, 2024 18:52
@jsdt jsdt added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 0b1beec Nov 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfops bfops bfops approved these changes

@cloutiertyler cloutiertyler Awaiting requested review from cloutiertyler cloutiertyler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsdt @bfops