Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify benchmarking wrappers #1951

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Simplify benchmarking wrappers #1951

merged 2 commits into from
Nov 6, 2024

Conversation

RReverser
Copy link
Contributor

Description of Changes

  • Reuse same runtime between module and db benchmarks.
  • Use Criterion's to_async for async benchmarks.
  • Reorder fields of SpacetimeModule to avoid the Option<ModuleHandle> hack - Rust has a guaranteed drop order that we can rely on.
  • Avoid cloning and batching of argument product values, use references instead.

This both simplifies benchmarking code and reduces the timing overhead a bit.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

 - Reuse same runtime between module and db benchmarks.
 - Use Criterion's `to_async` for async benchmarks.
 - Reorder fields of `SpacetimeModule` to avoid the `Option<ModuleHandle>` hack - Rust has a guaranteed drop order that we can rely on.
 - Avoid cloning and batching of argument product values, use references instead.

This both simplifies benchmarking code and reduces the timing overhead a bit.
@RReverser RReverser requested review from kazimuth and mamcx November 6, 2024 16:09
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RReverser RReverser added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 6d712b4 Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants