Remove IO macros #1929
Merged
Remove IO macros #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and println with log::info!
bfops
added
release-any
bfops
added
abi-break
…' into bfops/remove-io-macros
cloutiertyler
approved these changes
Dec 3, 2024
gefjon
added a commit
that referenced
this pull request
Jan 9, 2025
Likely by mistake, #1929 rewrote the `quickstart-chat` client to use `log::info!` and `log::error!` for output. In addition to needlessly adding complexity to a quickstart project, this was broken because that program didn't install a logger, so it produced no output at all. This commit reverts those changes, returning to `println`/`eprintln` output in the quickstart-chat client. We could use `log::` macros and install a logger, but then we'd have to explain installing a logger in the quickstart guide. This commit also makes me a codeowner of the `quickstart-chat` project, both the module and the client. I think extra scrutiny on these files is important because they're always supposed to exactly match the code presented in the tutorials, which prior to this commit they clearly did not.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Remove the spacetimedb version of common macros like
println!, per #1819.API and ABI breaking changes
Yes. This removes several spacetimedb macros. They should be replaced with
spacetimedb::log::info!,spacetimedb::log::error!, orspacetimedb::log::debug!.Expected complexity level and risk
2
Testing
Existing automated tests have been updated.