-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI - Replace clippy with a manual check #1928
Conversation
…move-io-macros' into bfops/replace-clippy
…and println with log::info!
…move-io-macros' into bfops/replace-clippy
…' into bfops/remove-io-macros
…move-io-macros' into bfops/replace-clippy
9d84c16
to
dcf325b
Compare
…into bfops/replace-clippy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the detailed testing spec. It's a little unfortunate that we warn even in commented code. I didn't think about that, but also that's not a very common case (although in principle it could come up). I'm good to approve this. We can consider an even better solution post 1.0
Description of Changes
We were apparently only using clippy to check for nonfunctional print statements (#1819).
This PR replaces our use of clippy (when building modules) with a manual check for disallowed print statements.
For me, this reduced the time of
cargo clean && time spacetime build
from2m15s
(with clippy) to1m30s
(without clippy).API and ABI breaking changes
Not breaking.
Expected complexity level and risk
2
Future work
The other items in #1819.
Testing
println!
to new module and observed thatspacetime build
produces an error:println!
is removed:lint-dir
that includes theprintln!
s inbuild.rs
:--lint-dir ''
skips linting: