Companion to spacetime-web#470 #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
reviewed
Oct 28, 2024
bfops
reviewed
Oct 28, 2024
bfops
force-pushed
the
puru/login-flow-renaming
branch
from
cb09221 to
edaf5b1
Compare
bfops
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
This worked for me when I tested with https://github.com/clockworklabs/spacetime-web/pull/470 (of course we shouldn't merge until that's merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This modifies login.rs with all the naming changes in https://github.com/clockworklabs/spacetime-web/pull/470
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
1
Testing
Tested it with
spacetime login --auth-host http://localhost:5173. The flow works well. To see the difference, open~/.spacetime/config.tomland compare the format of web_session_token to beforeTester can test this the same way as before, there is no user facing change here