CLI - Add login show and logout
#1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/cli-login' into bfops/cli-replace-token
…/cli-login' into bfops/cli-replace-token
…new-token-2' into bfops/cli-replace-token
…/cli-login' into bfops/cli-replace-token
…eplace-token' into bfops/cli-login-2
…o bfops/cli-login-2
cloutiertyler
approved these changes
Oct 29, 2024
PuruVJ
reviewed
Oct 30, 2024
PuruVJ
suggested changes
Oct 30, 2024
…o bfops/cli-login-2
bfops
changed the title
login show and login clearlogin show and logout
PuruVJ
approved these changes
Oct 31, 2024
mamcx
pushed a commit
that referenced
this pull request
Nov 5, 2024
Co-authored-by: Jeffrey Dallatezza <[email protected]> Co-authored-by: Zeke Foppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
login show(to show the current login)--clear-cachewith a separatelogoutsubcommand (which imo is easier to understand).conflicts_withchain with anArgGroupAPI and ABI breaking changes
Yes; this removes
--clear-cache.Expected complexity level and risk
2
Testing
login clearremoved the logins from my config filelogin showwhen not logged in gives an error messagelogin showwhen logged in shows my identitylogin show --tokenwhen logged in shows my identity + token