Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small naming fixes. Fixes database identity creation. #1892

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

cloutiertyler
Copy link
Contributor

Description of Changes

Removed more references to addresses. Fixed how identities are created for databases.

API and ABI breaking changes

Technically breaks the API of the database/info route

Expected complexity level and risk

2

Testing

Just the unit and integration tests.

@cloutiertyler cloutiertyler requested review from jsdt and gefjon October 23, 2024 16:42
Copy link
Contributor

@jsdt jsdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the naming fixes. This doesn't really change the identity creation, because without storing the sub used to create the identity, we won't be able to figure it out later.

@cloutiertyler cloutiertyler added this pull request to the merge queue Oct 24, 2024
Merged via the queue into master with commit fa960b3 Oct 24, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants