Remove CODEOWNERS from CLI codegen #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
added
release-any
gefjon
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I removed CODEOWNERS for the
generate/subdirectory of the CLI code, since this logic is pretty separate from the rest of the CLI.However I keep the codeowners on
generate/mod.rsbecause this includes the "interface" itself. I'm fine with somebody moving more code-generation code out ofmod.rsso that it doesn't require codeowner review.API and ABI breaking changes
No code changes.
Expected complexity level and risk
1
Testing
generate/rust.rsno longer requires codeowner approval: Test PR - Changegenerate/rust.rs#1887generate/mod.rsstill requires codeowner approval: Test PR - Modifygenerate/mod.rs#1888