-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle JWT tokens with oidc providers #1882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase, fmt, clippy, insta and to pass tests, but I trust that you'll get all those things done. Code & logic looks completely reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me. I would not block this from merging. However, I left several nit comments. Perhaps we can address them in another PR.
Description of Changes
This handles JWT tokens from other providers, as long as they host an openid config and public keys.
Tokens with the issuer "localhost" will go through the older flow.
There are some things that should be improved in future PRs:
NodeDelegate
.Expected complexity level and risk
Testing
This has unit tests that spin up a server hosting public keys to test fetching and validation.