CLI - Fix spacetime server edit failing on renames
#1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
commented
Oct 17, 2024
bfops
commented
Oct 17, 2024
lcodes
pushed a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Zeke Foppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
spacetime server edithad a bug during renames, where it would try to access the server config by the old name, causing an error.This must have been broken for a long time. The code has been in this state for a while, looks like about a year from the git history (a1e9984).
API and ABI breaking changes
No. Bugfix.
Expected complexity level and risk
1
Testing
I added a smoketest.