Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put ExecutionContext inside the Tx context #1876

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Oct 17, 2024

Description of Changes

As a preparatory step for further PRs, like those related to the new Query Engine, most usages of ExecutionContext as an additional context in database calls are removed and put inside the Tx contexts instead.

API and ABI breaking changes

  • This pr touches everything related to the db
  • It could change the metrics. There were many places where the ExecutionContext was overwritten and now it should provide more exact measurements.
  • Is necessary to check if it passes correctly the Identity & Address of replicas

Expected complexity level and risk

3

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@mamcx mamcx added Do not merge Do not merge PRs with this label without coordinating further release-1.0 api-break labels Oct 17, 2024
@mamcx mamcx self-assigned this Oct 17, 2024
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to comment that I am good to approve the change to the traits when this is ready.

@mamcx mamcx force-pushed the mamcx/execution-context-embed branch from 1d3e1d7 to aa7473a Compare October 21, 2024 15:43
@mamcx mamcx mentioned this pull request Oct 21, 2024
1 task
@mamcx mamcx force-pushed the mamcx/execution-context-embed branch from aa7473a to d7260fc Compare October 22, 2024 18:02
@mamcx mamcx marked this pull request as ready for review October 22, 2024 19:07
@joshua-spacetime
Copy link
Collaborator

@cloutiertyler this is ready for your approval

@mamcx
Copy link
Contributor Author

mamcx commented Oct 23, 2024

@cloutiertyler this is ready for your approval

Pls wait until I merge #1880 so it will be easier to read...

Ok, now is done!

@mamcx mamcx force-pushed the mamcx/execution-context-embed branch from 9dfcae3 to d029d1c Compare October 23, 2024 17:56
@mamcx mamcx removed the Do not merge Do not merge PRs with this label without coordinating further label Oct 24, 2024
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mamcx mamcx force-pushed the mamcx/execution-context-embed branch from 037a7a6 to 4d546bc Compare October 29, 2024 15:36
@mamcx mamcx enabled auto-merge October 29, 2024 16:23
@mamcx mamcx added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit a6a6c4f Oct 29, 2024
7 of 8 checks passed
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that makes an API breaking change release-1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants