-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put ExecutionContext
inside the Tx context
#1876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to comment that I am good to approve the change to the traits when this is ready.
1d3e1d7
to
aa7473a
Compare
aa7473a
to
d7260fc
Compare
crates/core/src/db/datastore/locking_tx_datastore/committed_state.rs
Outdated
Show resolved
Hide resolved
@cloutiertyler this is ready for your approval |
Pls wait until I merge #1880 so it will be easier to read... Ok, now is done! |
9dfcae3
to
d029d1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
037a7a6
to
4d546bc
Compare
Description of Changes
As a preparatory step for further PRs, like those related to the new
Query Engine
, most usages ofExecutionContext
as an additional context in database calls are removed and put inside theTx
contexts instead.API and ABI breaking changes
ExecutionContext
was overwritten and now it should provide more exact measurements.Identity
&Address
of replicasExpected complexity level and risk
3
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!