Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Durability Provider #1864

Merged
merged 11 commits into from
Nov 19, 2024
Merged

Durability Provider #1864

merged 11 commits into from
Nov 19, 2024

Conversation

Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Oct 16, 2024 •
edited
Loading

Description of Changes

  • Added fn leader to NodeDelegate, to abstract HostController.
  • Added dyn DurabilityProvider in HostController.
  • Update message::Database to include ReplicationConfig

@Shubham8287 Shubham8287 force-pushed the shub/dynamic-durability branch 3 times, most recently from 6caa640 to 86dc01e Compare October 16, 2024 18:08
@Shubham8287 Shubham8287 force-pushed the shub/dynamic-durability branch from 86dc01e to a000a4f Compare October 16, 2024 18:17
@Shubham8287 Shubham8287 force-pushed the shub/dynamic-durability branch from 82a521b to 7e91dba Compare October 23, 2024 08:14
@Shubham8287 Shubham8287 force-pushed the shub/dynamic-durability branch from 4b2a812 to b577f44 Compare October 23, 2024 09:06
kim
kim reviewed Oct 28, 2024
View reviewed changes
@bfops bfops added backward-compatible release-any To be landed in any release window labels Oct 28, 2024
Shubham8287 and others added 2 commits November 11, 2024 12:28
@Shubham8287
DurabilityProvider
a0ee21b
@Shubham8287 @kim
Update crates/client-api/src/lib.rs
d25746a 
Co-authored-by: Kim Altintop <[email protected]>
Signed-off-by: Shubham Mishra <[email protected]>
@Shubham8287 Shubham8287 changed the title create dynamic durability Durability Provider Nov 11, 2024
@Shubham8287 @kim
Update crates/client-api/src/lib.rs
fe43cfd 
Co-authored-by: Kim Altintop <[email protected]>
Signed-off-by: Shubham Mishra <[email protected]>
@Shubham8287 Shubham8287 force-pushed the shub/dynamic-durability branch 2 times, most recently from 1d5c505 to 245981d Compare November 11, 2024 20:12
@Shubham8287 Shubham8287 force-pushed the shub/dynamic-durability branch from 245981d to f336c2d Compare November 13, 2024 06:47
@Shubham8287 Shubham8287 force-pushed the shub/dynamic-durability branch from f336c2d to 1a819f4 Compare November 13, 2024 06:50
kim
kim approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Shubham8287 Shubham8287 added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 9c64d1f Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim kim kim approved these changes

Assignees
No one assigned
Labels
backward-compatible release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shubham8287 @kim @bfops