Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ARM64 and AMD64 docker builds more resilient #1844

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jdetter
Copy link
Collaborator

@jdetter jdetter commented Oct 11, 2024

Description of Changes

Please describe your change, mention any related tickets, and so on here.

  • During the release of 0.12.0 we had an issue where we pushed a tag, deleted that tag and then pushed the tag again. It is known that typically updating tags isn't supported in our CI and in this case this caused a downstream issue with the docker container images that get built for the website. This PR makes the build more resilient to hopefully prevent future issues.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Not breaking

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

1

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

I pushed a tag vjdetter-test-tag which then built successfully (expected) https://github.com/clockworklabs/SpacetimeDB/actions/runs/11293014896
Then I deleted the tag via:

git push -u origin :vjdetter-test-tag

Then I pushed the tag again (with a different commit!) and it also built successfully https://github.com/clockworklabs/SpacetimeDB/actions/runs/11293114243

@jdetter jdetter marked this pull request as ready for review October 11, 2024 13:24
@jdetter jdetter changed the title Prune tags before checking out Make ARM64 and AMD64 docker builds more resilient Oct 11, 2024
@jdetter jdetter added this pull request to the merge queue Oct 11, 2024
Merged via the queue into master with commit 66ea22f Oct 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants