Websocket API: Light transaction updates & NoSuccessNotify
#1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/websocket-light
branch
from
96c58b8 to
ff2e1d8
Compare
Centril
force-pushed
the
centril/websocket-gzip
branch
from
7402785 to
266d6fa
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
ff2e1d8 to
32e1a6c
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
c7729ee to
2a9424e
Compare
Centril
requested review from
bfops,
jdetter and
cloutiertyler
as code owners
Centril
force-pushed
the
centril/websocket-light
branch
from
a8e222e to
b51292b
Compare
|
Looks like the tests are failing? |
Centril
force-pushed
the
centril/websocket-light
branch
5 times, most recently
from
da45a60 to
e39d51e
Compare
Centril
force-pushed
the
centril/websocket-light
branch
2 times, most recently
from
e2fabc9 to
0cb3389
Compare
|
@Centril I'm happy to review the CLI changes - Do you have recommendations on how to test this? Should I just regenerate bindings for an example client for each language? |
Centril
force-pushed
the
centril/websocket-light
branch
from
0cb3389 to
22de99e
Compare
gefjon
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Ideally I would like to see tests added to the Rust SDK test suite which exercise this new functionality. If time is a concern, these could be added in a follow-up. I am happy to assist in writing the tests, but I don't think I have a strong enough grasp of the intended semantics to actually write them myself.
I would very much like clarification on the ReducerContext.sender passed to reducers whose callers requested no-notify.
I've also left many suggestions which are all: don't document the WS protocol on user-facing parts of the SDK. The WS protocol should be abstracted away to users of the SDK.
gefjon
approved these changes
Oct 22, 2024
bfops
reviewed
Oct 22, 2024
bfops
approved these changes
Oct 22, 2024
Centril
force-pushed
the
centril/websocket-light
branch
from
c659ca4 to
7e91c80
Compare
cloutiertyler
approved these changes
Oct 23, 2024
Centril
force-pushed
the
centril/websocket-light
branch
2 times, most recently
from
b6689e9 to
33e815c
Compare
Centril
commented
Oct 23, 2024
Centril
force-pushed
the
centril/websocket-light
branch
from
eafc64b to
9c85842
Compare
… unless NoSuccessNotify
…n 1.0 would be breaking) Co-authored-by: Phoebe Goldman <[email protected]> Signed-off-by: Mazdak Farrokhzad <[email protected]>
Signed-off-by: Mazdak Farrokhzad <[email protected]>
Centril
force-pushed
the
centril/websocket-light
branch
from
9c85842 to
01d3cd9
Compare
Centril
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Nov 4, 2024
## Description of Changes Adds C# sdk support for clockworklabs/SpacetimeDB#1812. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1812 ## Testsuite SpacetimeDB branch name: centril/websocket-light --------- Co-authored-by: Tyler Cloutier <[email protected]> Co-authored-by: John Detter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Does two things:
TransactionUpdateLightthat consists only of therequest_idand theDatabaseUpdate<F>. This is emitted when the query param&light=trueis set (unless the update is sent to the caller in which case a full update is sent).flags: enum CallReducerFlags { FullUpdate, NoSuccessNotify }toClientMessage. WhenNoSuccessNotifyis set, the host will not send back an empty update to the caller on success without the caller having subscribed to any affected queries. This is exposed in the SDK viactx.set_reducer_flags.my_reducer(CallReducerFlags::NoSuccessNotify). When the defaultFullUpdateis used, full updates are sent, whether the caller was subscribed to the relevant queries or not.TODO:
API and ABI breaking changes
This breaks the websocket API/protocol.