Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Maps for you! #1770

Merged
merged 1 commit into from
Oct 15, 2024
Merged

No Maps for you! #1770

merged 1 commit into from
Oct 15, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Sep 30, 2024

Description of Changes

Remove AlgebraicType::Map and AlgebraicValue::Map and all the consequence changes necessary.

API and ABI breaking changes

Yes.

RReverser
RReverser approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@RReverser RReverser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a simple man, I see someone removing tons of code, I click Approve.

@Centril Centril force-pushed the centril/no-maps-for-you branch from d668005 to 859d00e Compare September 30, 2024 21:26
@Centril Centril enabled auto-merge September 30, 2024 21:31
@Centril Centril disabled auto-merge September 30, 2024 21:32
@Centril Centril force-pushed the centril/no-maps-for-you branch 4 times, most recently from 4f18679 to 03c5cb9 Compare October 3, 2024 18:21
@bfops bfops added release-1.0 abi-break A PR that makes an ABI breaking change api-break labels Oct 8, 2024
@Centril Centril force-pushed the centril/no-maps-for-you branch from 03c5cb9 to fbcf946 Compare October 15, 2024 09:00
bfops
bfops approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI changes LGTM

@Centril Centril force-pushed the centril/no-maps-for-you branch from fbcf946 to 4a596fb Compare October 15, 2024 22:14
@Centril Centril force-pushed the centril/no-maps-for-you branch from 4a596fb to 9131be8 Compare October 15, 2024 22:20
@Centril Centril enabled auto-merge October 15, 2024 22:33
@Centril Centril added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit 06cc688 Oct 15, 2024
7 of 8 checks passed
@Centril Centril deleted the centril/no-maps-for-you branch October 15, 2024 23:11
lcodes pushed a commit that referenced this pull request Oct 25, 2024
@Centril @lcodes
No Maps for you! (#1770)
90f942e
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RReverser RReverser RReverser approved these changes

@bfops bfops bfops approved these changes

@jdetter jdetter Awaiting requested review from jdetter jdetter is a code owner

@cloutiertyler cloutiertyler Awaiting requested review from cloutiertyler cloutiertyler is a code owner

Assignees
No one assigned
Labels
abi-break A PR that makes an ABI breaking change api-break A PR that makes an API breaking change release-1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Centril @bfops @RReverser