-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the system table for row level security #1746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. We've ended up with a lot of boxes to check when adding stuff to the schema, good job navigating all that. Maybe we should document the process somewhere.
You may also want to add row-level-security to crates/schema/src/auto_migrate.rs
. It seems to me that arbitrary changes to row-level security can be performed automatically.
If we need to check the validity of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main questions are:
- Can we get rid of the
name
column? I believe we can. - Do we need a primary key column? I believe we don't.
5c23955
to
3085324
Compare
fea437d
to
44aec4f
Compare
ef7b76a
to
250da82
Compare
250da82
to
89b1722
Compare
Yes, is already done |
Description of Changes
NOTE: The design changes after several meetings with the team to improve the ergonomics of module compilation.
Add a new system table
st_row_level_security
to store theSQL
queries for row-level security.This is a first step to add support for authorization. This PR doesn't validate that the queries are valid, that will done when #1602 is implemented.
Closes #1600.
Expected complexity level and risk
2: It adds a new
system table
and because we haven't yet migrated support for them, it needs a recreate of the db.Testing
SQL cli
the new table