WASM ABI: implement console ABIs #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
requested review from
RReverser,
coolreader18,
kazimuth,
gefjon and
joshua-spacetime
RReverser
reviewed
Sep 4, 2024
coolreader18
reviewed
Sep 5, 2024
coolreader18
approved these changes
Sep 5, 2024
Centril
force-pushed
the
centril/datastore_insert_bsatn
branch
from
6805083 to
4a07054
Compare
Centril
force-pushed
the
centril/console-timer-start
branch
from
554ad0b to
aef1c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adjusts the docs of
console_logandspan_{start, end}are nowconsole_timer_{start, end}with some semantics adjusted according to the proposal. For the latter two, C# support did not exist, so this is not added in this PR.cc #1460