[WASM ABI 1.0] Fix bytes_source_read
#1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decoding reducer args, `bytes_source_read` would incorrectly set instead of advance the read cursor, causing decoding of large args to fail.
bfops
reviewed
Aug 28, 2024
| @@ -848,7 +848,7 @@ impl WasmInstanceEnv { | |||
| env.call_reducer_args = None; | |||
| Ok(-1i32) | |||
| } else { | |||
| *cursor = can_read_len; | |||
| *cursor += can_read_len; | |||
There was a problem hiding this comment.
@Centril why did this pass all the smoketests? Can we add test coverage for this?
There was a problem hiding this comment.
afaiu, it only fails when the reducer args are past a certain size. I didn't look close enough to know what size exactly, perhaps then we can make a test which fails in this repo.
coolreader18
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoding reducer args,
bytes_source_readwould incorrectly setinstead of advance the read cursor, causing decoding of large args to
fail.
Expected complexity level and risk
1
Testing
This would cause non-public tests to fail, which use large reducer args.
We may want to create a large-args test case here as well.