WASM ABI: insert -> datastore_insert_bsatn & impl new semantics
#1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
commented
Aug 27, 2024
| /// - `BSATN_DECODE_ERROR`, when `row` cannot be decoded to a `ProductValue`. | ||
| /// typed at the `ProductType` the table's schema specifies. | ||
| /// - `UNIQUE_ALREADY_EXISTS`, when inserting `row` would violate a unique constraint. | ||
| /// - `SCHEDULE_AT_DELAY_TOO_LONG`, when the delay specified in the row was too long. |
There was a problem hiding this comment.
NOTE TO SELF: This is different from the proposal, but also necessary. Add to proposal once impl work is done.
Centril
commented
Aug 27, 2024
| /// # Traps | ||
| /// | ||
| /// Traps if: | ||
| /// - `row_len_ptr` is NULL or `row_len` is not in bounds of WASM memory. |
There was a problem hiding this comment.
NOTE TO SELF: row_len_ptr is different from the proposal, but also necessary. Add to proposal once impl work is done.
RReverser
reviewed
Aug 27, 2024
RReverser
approved these changes
Aug 27, 2024
|
Reviewed both Rust and C# on this one; aside from one minor issue above, the rest looks good. |
Centril
force-pushed
the
centril/datastore_delete_all_by_eq_bsatn
branch
from
e1269ee to
11da884
Compare
Base automatically changed from
centril/datastore_delete_all_by_eq_bsatn
to
master
September 3, 2024 12:42
Centril
force-pushed
the
centril/datastore_insert_bsatn
branch
3 times, most recently
from
556db01 to
dc305c2
Compare
Centril
force-pushed
the
centril/datastore_insert_bsatn
branch
from
6805083 to
4a07054
Compare
cloutiertyler
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rename
inserttodatastore_insert_bsatnand impl the new semantics wrt. auto-inc columns.Also, fix the semantics when multiple sequences exist on a table.
cc #1460
Fixes #1640