WASM ABI: iter_start -> datastore_table_scan_bsatn
#1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/datastore-table-scan-bsatn
branch
from
e31db25 to
0e2807a
Compare
gefjon
approved these changes
Aug 26, 2024
RReverser
reviewed
Aug 27, 2024
| /// - `NOT_IN_TRANSACTION`, when called outside of a transaction. | ||
| /// - `NO_SUCH_TABLE`, when `table_id` is not a known ID of a table. | ||
| // #[tracing::instrument(skip_all)] | ||
| pub fn datastore_table_scan_bsatn( |
There was a problem hiding this comment.
Those diffs really throw me off tbh - not much of a problem when it's 1 line, but harder to compare when it's an entire function.
Could be nice to have them in the same position just to quickly verify that functionality didn't change, only names did.
There was a problem hiding this comment.
Could be nice to have them in the same position just to quickly verify that functionality didn't change, only names did.
(I'm intentionally moving these to be in the same order as the proposal.)
There was a problem hiding this comment.
Yeah you mentioned that on PRs with smaller changes, just saying it makes reviews (and, I imagine, Git blame) somewhat harder.
Is the order matching the proposal really that important?
Centril
force-pushed
the
centril/datastore-table-row-count
branch
from
d76b397 to
7c3a4a7
Compare
Centril
force-pushed
the
centril/datastore-table-scan-bsatn
branch
from
0e2807a to
5c37b10
Compare
Centril
changed the base branch from
centril/datastore-table-row-count
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rename
iter_start->datastore_table_scan_bsatn.