WASM ABI: get_table_id -> table_id_from_name
#1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
approved these changes
Aug 26, 2024
Centril
force-pushed
the
centril/table-id-from-name
branch
2 times, most recently
from
8d1307b to
ffd4b42
Compare
Centril
commented
Aug 26, 2024
| /// | ||
| /// Returns an error: | ||
| /// | ||
| /// - `NOT_IN_TRANSACTION`, when called outside of a transaction. |
There was a problem hiding this comment.
Note to self: this was erroneously not part of the proposal, so change the proposal once the impl work is done.
RReverser
reviewed
Aug 26, 2024
RReverser
reviewed
Aug 26, 2024
Centril
force-pushed
the
centril/table-id-from-name
branch
from
ffd4b42 to
3e8eccf
Compare
Centril
force-pushed
the
centril/row-iter-bsatn-advance
branch
from
b62234a to
ae0b238
Compare
- added note + routing to NOT_IN_TRANSACTION - removed LOOKUP_NOT_FOUND
Centril
force-pushed
the
centril/table-id-from-name
branch
from
3e8eccf to
6786514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rename as the title says.
cc #1460