Allow converting new ModuleDef to old TableSchema #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
force-pushed
the
jgilles/v8validation
branch
from
de74b8d to
e9634c1
Compare
kazimuth
force-pushed
the
jgilles/newdef2schema
branch
from
0b26485 to
e5413d8
Compare
kazimuth
force-pushed
the
jgilles/v8validation
branch
2 times, most recently
from
a8e90e1 to
06a9e70
Compare
kazimuth
force-pushed
the
jgilles/newdef2schema
branch
2 times, most recently
from
901e2eb to
4e617bb
Compare
kazimuth
force-pushed
the
jgilles/v8validation
branch
from
3ad5756 to
8834292
Compare
kazimuth
force-pushed
the
jgilles/newdef2schema
branch
from
4e617bb to
c7a268b
Compare
bananas Clean up Fix deprecation errors Vanquish clippy
kazimuth
force-pushed
the
jgilles/newdef2schema
branch
from
c7a268b to
4db02b7
Compare
cloutiertyler
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This was not painful at all! The code is a mess but the tests pass, the paths commute! Gonna rewrite to be cleaner, but the logic is there.
It should be possible to go in reverse from TableSchema -> ModuleDef via RawModuleDefv8, I have not implemented that yet. Eventually we'll update TableSchema to look like v9 and then we can throw out that path.
API and ABI breaking changes
None
Expected complexity level and risk
1, this is tricky but I think I've got it right.
Testing
We test that this produces identical results for the old and the new path for all of the modules in
modules(up to a small amount of sorting).