Updated docker internal port to 3000 #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
force-pushed
the
jdetter/change-internal-docker-port-to-3000
branch
from
607162e to
bf04dd9
Compare
kurtismullins
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Looks good to me. We will need to fix references and usage in other places including:
- spacetimedb.com's instructions to download and use it
- any servers using the pre-existing image that get upgraded
- any docs that reference the port number in the Docker container
I've created a PR in our internal repo for the website which needs to be rolled out as part of 0.12, the latter 2 points here I think we will have to fix as we find things that are wrong. I will do a quick pass on the spacetime-docs repo to see if there anything in there that needs to be updated and if I find anything I will open PR(s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
I have updated the port used by the docker-compose file toI have updated the default port for3000spacetimedb-standaloneto be3000. Originally we were using port80internally and then in the docker-compose file (and in other places) we were mapping3000 => 80. This works fine but it was very confusing that you would get this start-up message:This PR rectifies the problem and now you get the following start-up message:
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
This is technically breaking but not in a way that actually matters. I've only updated the docker-compose file, not the default port (which is actually still set to 80 right now).This is now a somewhat larger breaking change because everywhere where we use this docker container and we're not using the default
docker-compose.ymlthen we have to update the port to be 3000 instead of 80. Notibly this will likely affect our ansible playbooks.Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
docker-compose upto bring the container up and try to connect to it. It should work exactly as it worked before except now the start-up printout has been updated to use port 3000 internally.