Update SQL AST in accordance with the SQL spec #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
added
enhancement
mamcx
commented
Aug 21, 2024
crates/sql/src/ast/subscription.rs
Outdated
| //! = columnExpr '=' columnExpr | ||
| //! | predicate_on AND predicate_on | ||
| //! ; | ||
| //! |
There was a problem hiding this comment.
This is an addition to the spec, because the predicate allows expressions that will not optimize.
crates/sql/src/errors.rs
Outdated
| #[display(fmt = "Change to several queries")] | ||
| ChangeOrToManyQueries, | ||
| } | ||
|
|
There was a problem hiding this comment.
It could be good idea to brainstorm which suggestion could enhance the experience of errors.
crates/sql/src/errors.rs
Outdated
| } | ||
|
|
||
| #[derive(Error, Debug)] | ||
| pub enum SqlUnsupported { |
There was a problem hiding this comment.
A single place to see what we need to add later, maybe.
Centril
reviewed
Aug 21, 2024
mamcx
added
release-1.0
and removed
release-any
joshua-spacetime
force-pushed
the
mamcx/sql-ast
branch
from
baa11b1 to
0322ea0
Compare
Closes #1563. Co-authored-by: joshua-spacetime <[email protected]>
joshua-spacetime
force-pushed
the
mamcx/sql-ast
branch
from
40b852d to
f9c4130
Compare
joshua-spacetime
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The first step towards updating the parsing of
SQLto match the spec forSpacetimeDB, as asked by ticket #1563.This is the syntactic parser, without being integrated yet into the codebase, to be done later.
Expected complexity level and risk
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
ast