[WASM ABI 1.0] impl __call_reducer__ & __describe_module__ using bytes_sink_write
#1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/bytes-source-read
branch
from
cedf36a to
08590c7
Compare
Centril
force-pushed
the
centril/bytes-sink-write
branch
2 times, most recently
from
bd8389f to
98942b8
Compare
Centril
force-pushed
the
centril/bytes-sink-write
branch
from
98942b8 to
2a9ae03
Compare
RReverser
reviewed
Aug 21, 2024
RReverser
reviewed
Aug 21, 2024
Centril
force-pushed
the
centril/bytes-sink-write
branch
2 times, most recently
from
8e26b2c to
3e45a7a
Compare
RReverser
approved these changes
Aug 21, 2024
Centril
force-pushed
the
centril/bytes-sink-write
branch
from
3057fa9 to
fd209d1
Compare
coolreader18
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This adds
_bytes_sink_writeand implements__call_reducer__,__describe_module__, and__setup__with it.Meanwhile,
_buffer_len,_buffer_consume, and_buffer_allocare fully removed this time around (some missing stuff from previous PR).cc #1460