fix: Always remember to release a read only tx #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/fix/release-tx
branch
from
5ce3b74 to
edd64ac
Compare
joshua-spacetime
removed this pull request from the merge queue due to a manual request
joshua-spacetime
force-pushed
the
joshua/fix/release-tx
branch
from
edd64ac to
5b57908
Compare
Previously in the case of incremental subscription updates, we were not releasing downgraded transactions.
joshua-spacetime
force-pushed
the
joshua/fix/release-tx
branch
from
f08232b to
03350c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Previously we were not releasing downgraded transactions for incremental subscription updates.
API and ABI breaking changes
None
Expected complexity level and risk
1