Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds for MacOS amd64 platform #1598

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

kurtismullins
Copy link
Contributor

@kurtismullins kurtismullins commented Aug 16, 2024

Description of Changes

The builds for Intel Mac are actually targeting Apple Silicon (arm64). I believe this is due to a change in Github's MacOS runner's newer generations.

The change here explicitly targets the Intel architecture.

API and ABI breaking changes

n/a

Expected complexity level and risk

1 - If it doesn't work, CI should fail and we'll know about it before any harm is done.

Testing

  • Run it and verify that it produces a binary for the correct architeceture now

Build Log from this branch: https://github.com/clockworklabs/SpacetimeDB/actions/runs/10423008363

Local output testing that the files were built for the correct platforms:

kurtis@mbp fix-mac-on-intel-builds % ls
spacetime.darwin-amd64.tar.gz spacetime.darwin-arm64.tar.gz
kurtis@mbp fix-mac-on-intel-builds % tar xzvf spacetime.darwin-amd64.tar.gz
x spacetime
kurtis@mbp fix-mac-on-intel-builds % ls
spacetime                     spacetime.darwin-amd64.tar.gz spacetime.darwin-arm64.tar.gz
kurtis@mbp fix-mac-on-intel-builds % file spacetime
spacetime: Mach-O 64-bit executable x86_64
kurtis@mbp fix-mac-on-intel-builds % mv spacetime spacetime_x86_64
kurtis@mbp fix-mac-on-intel-builds % tar xzvf spacetime.darwin-arm64.tar.gz
x spacetime
kurtis@mbp fix-mac-on-intel-builds % file spacetime
spacetime: Mach-O 64-bit executable arm64
kurtis@mbp fix-mac-on-intel-builds % mv spacetime spacetime_arm64
kurtis@mbp fix-mac-on-intel-builds % ls
spacetime.darwin-amd64.tar.gz spacetime.darwin-arm64.tar.gz spacetime_arm64               spacetime_x86_64
kurtis@mbp fix-mac-on-intel-builds % file spacetime_x86_64 spacetime_arm64
spacetime_x86_64: Mach-O 64-bit executable x86_64
spacetime_arm64:  Mach-O 64-bit executable arm64

@kurtismullins kurtismullins force-pushed the kurtis/fix-mac-on-intel-builds branch from f29598c to 0d591b0 Compare August 16, 2024 17:37
@kurtismullins kurtismullins marked this pull request as ready for review August 16, 2024 17:38
@cloutiertyler cloutiertyler added this pull request to the merge queue Aug 17, 2024
Merged via the queue into master with commit 96b8d43 Aug 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants