-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty ColList
#1588
Allow empty ColList
#1588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice to be able to use collect
.
I was sketching an implementation of sort
as well, since I need it for finding indexes for unique constraints, but it's a little too much added code to do with suggestions.
I'll open a followup PR once this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump Rust to 1.80.1 as this turned out to be required due to compiler bugs on 1.78.
I would like a more detailed description than this, and would also like to know why bumping to 1.79 is insufficient. I would also strongly prefer the version bump happen in a separate PR, rather than sneaking it in alongside another change.
e7a1cd3
to
e595ce2
Compare
69dee6c
to
d738f9f
Compare
ColList
+ Bump Rust to 1.80.1ColList
It was something at some point which caused complaints about |
Description of Changes
Fix the bug found in #1585 by allowing
ColList
s to be empty, as we actually try to use the type as a possibly-empty list in some places (which is why the tests failed in #1585).API and ABI breaking changes
None
Expected complexity level and risk
2, some unsafe related code affected, but there's less unsafe code now.
Testing