Add helpers and change CollectAllErrors to be more composable
#1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
force-pushed
the
jgilles/error-stream-updates
branch
from
c36f3f3 to
8ac75ee
Compare
gefjon
approved these changes
Aug 13, 2024
kazimuth
force-pushed
the
jgilles/error-stream-updates
branch
from
f4bb9fd to
3652793
Compare
Merged
kazimuth
force-pushed
the
jgilles/error-stream-updates
branch
from
55e652a to
b2a0f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This updates
CollectAllErrorsto be more composable and adds some helper methods + a testing macro.Extracted from #1572.
API and ABI breaking changes
Technically API break, but nobody is using this yet.
Expected complexity level and risk
0
Testing
Added tests.