[CI] Do not use branch names when publishing container images #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removes the creation of Docker Container Images with branch names as tags.
AMD/Intel Image Build
ARM Image Build
Both images merged into a multi-platform image
The created images in Dockerhub
Side Note: It is much nicer to cross-reference related/identical images in Github's Artifact Repository than it is in Dockerhub. Perhaps we should consider only using Dockerhub for
spacetimedb:latestand tagged releases?API and ABI breaking changes
n/a
Expected complexity level and risk
1
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
n/a
Testing
v*and verified that the tag names are correct by looking at the CI output and cross-referencing DockerHub.