Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schema crate publishable #1569

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Make schema crate publishable #1569

merged 3 commits into from
Aug 7, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Aug 6, 2024

Description of Changes

Some tiny tweaks to the schema crate that make it publish properly to crates.io in our release process.

API and ABI breaking changes

Nah

Expected complexity level and risk

1

Testing

I ran tools/publish-crates.sh during the release process and it worked successfully (but not without these changes).

bfops added a commit that referenced this pull request Aug 6, 2024
@@ -2,6 +2,8 @@
name = "spacetimedb-schema"
version.workspace = true
edition.workspace = true
license-file = "LICENSE"
description = "Schema library for SpacetimeDB"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazimuth feel free to improve this - I just put in some boilerplate text to get it to publish successfully

@bfops bfops changed the title Bfops/schema crate fix Fix schema crate publishing Aug 6, 2024
@bfops bfops marked this pull request as ready for review August 6, 2024 19:30
@bfops bfops requested a review from kazimuth August 6, 2024 19:31
@bfops bfops changed the title Fix schema crate publishing Make schema crate publishable Aug 6, 2024
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kazimuth kazimuth added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit a2f812b Aug 7, 2024
12 checks passed
bfops added a commit that referenced this pull request Sep 2, 2024
@bfops bfops deleted the bfops/schema-crate-fix branch September 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants