Change ResolveRefs to return a Result rather than an Option #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
force-pushed
the
jgilles/resolve_refs_result
branch
2 times, most recently
from
177c335 to
d48185a
Compare
bfops
added
release-any
Centril
approved these changes
Aug 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Update crates/bindings/src/rt.rs Co-authored-by: Mazdak Farrokhzad <[email protected]> Signed-off-by: james gilles <[email protected]>
kazimuth
force-pushed
the
jgilles/resolve_refs_result
branch
from
cf3d410 to
6079bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This allows constructing better errors during module validation.
API and ABI breaking changes
This is an API break.
Expected complexity level and risk
0
Testing
CI