-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SATS: Flatten AlgebraicType
, getting rid of BuiltinType
#1559
Conversation
Have you done any testing of the codegen @Centril? AFAICT the changes seem more or less minimal for what we need to do. |
dc584f1
to
9824a26
Compare
9824a26
to
e591a97
Compare
958efdb
to
7dd030d
Compare
The Rust codegen is tested in CI but the C# sdk tests seem to be broken in CI. This PR appears to slightly break the C# SDK which clockworklabs/com.clockworklabs.spacetimedbsdk#116 is meant to fix. However, I don't know how to test the combination of this and that PR locally. I'm hoping that @bfops can help me out here. |
The easiest way to at least get the command-line tests (
replace |
Ah actually it requires a |
(To be clear, the C# SDK tests are not a required check on PRs - they're there to effectively warn you that something downstream will be broken and will need fixing once this merges) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, but lgtm.
Signed-off-by: Mazdak Farrokhzad <[email protected]>
Co-authored-by: Mazdak Farrokhzad <[email protected]> Signed-off-by: joshua-spacetime <[email protected]>
Signed-off-by: Mazdak Farrokhzad <[email protected]>
5984ca5
to
c504aa5
Compare
## Description of Changes Required to make "SDK Tests" pass in clockworklabs/SpacetimeDB#1559. ## API Not breaking. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1559 --------- Co-authored-by: Zeke Foppa <[email protected]>
## Description of Changes Required to make "SDK Tests" pass in clockworklabs/SpacetimeDB#1559. ## API Not breaking. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1559 --------- Co-authored-by: Zeke Foppa <[email protected]>
## Description of Changes Required to make "SDK Tests" pass in clockworklabs/SpacetimeDB#1559. ## API Not breaking. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1559 --------- Co-authored-by: Zeke Foppa <[email protected]>
Description of Changes
Take 2 of #379.
API and ABI breaking changes
Any API/ABI relying on
AlgebraicType
s BSATN serialization will break.Expected complexity level and risk
3, where the complexity is primarily in codegen.