core: Start system table ids at 1 #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim
force-pushed
the
kim/1-based-system-table-ids
branch
from
a1c8a2c to
dc1b372
Compare
|
Updated to start all autoinc columns of system tables at 1. |
Centril
approved these changes
Jul 29, 2024
|
Wait, is this not an ABI break? |
|
@bfops Sorry, no, it's not. I initially thought it was, but we're not storing any id in the commitlog, and user-defined tables start at 4097 (not system tables + 1). |
kim
force-pushed
the
kim/1-based-system-table-ids
branch
2 times, most recently
from
a25475c to
7cb0dde
Compare
Start all autoinc id columns within the system schema with 1 instead of 0. Zero is the sentinel value to increment the autoinc sequence when inserting, so using 0 as an actual value can lead to confusion and subtle bugs.
kim
force-pushed
the
kim/1-based-system-table-ids
branch
from
7cb0dde to
f9fa796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start all autoinc id columns within the system schema with 1 instead of
0.
Zero is the sentinel value to increment the autoinc sequence when
inserting, so using 0 as an actual value can lead to confusion and
subtle bugs.
Expected complexity level and risk
1