Add lib::db::{column_ordering, raw_def::v9} #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
force-pushed
the
jgilles/new_module_def
branch
from
e34c871 to
3e6a171
Compare
cloutiertyler
approved these changes
Jul 24, 2024
gefjon
reviewed
Jul 25, 2024
kazimuth
force-pushed
the
jgilles/new_module_def
branch
3 times, most recently
from
55cc541 to
63580e4
Compare
Centril
reviewed
Jul 29, 2024
crates/lib/src/db/raw_def/v9.rs
Outdated
| let column = column.as_ref(); | ||
| self.columns()? | ||
| .iter() | ||
| .position(|x| x.name.as_ref().map(|s| &s[..]) == Some(column)) |
There was a problem hiding this comment.
Suggested change
| .position(|x| x.name.as_ref().map(|s| &s[..]) == Some(column)) | |
| .position(|x| x.name.as_ref().is_some_and(|s| s == column)) |
(might need some tweaking to get the types right...)
There was a problem hiding this comment.
Turns out I should have been using .name() anyway :)
More comments One more comment Update crates/lib/src/db/column_ordering.rs Co-authored-by: Phoebe Goldman <[email protected]> Signed-off-by: james gilles <[email protected]> Update crates/lib/src/db/raw_def/v9.rs Co-authored-by: Tyler Cloutier <[email protected]> Signed-off-by: james gilles <[email protected]> Cargo fmt Reword things
Co-authored-by: Mazdak Farrokhzad <[email protected]> Signed-off-by: james gilles <[email protected]>
kazimuth
force-pushed
the
jgilles/new_module_def
branch
from
1222c83 to
93d1f1e
Compare
Centril
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is NOT an ABI or API break because we have enums now!!
I decided to split these out from the validation & migration code PR to make it easier to review.
I haven't added any code to work with these, just the definitions.
The new "test" features are going to be exercised in my next PR.
Expected complexity level and risk
a mild 1/5: this adds some new types that aren't used anywhere, which is perhaps slightly confusing.
Testing
CI should suffice.