Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: Make with_mut_schema clone-on-write #1530

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

kim
Copy link
Contributor

@kim kim commented Jul 19, 2024

Avoid incrementing the refcount of the schema before mutating, so it
gets modified in place if no other reference is live.

Expected complexity level and risk

1

Avoid incrementing the refcount of the schema before mutating, so it
gets modified in place if no other reference is live.
@kim kim added no runtime change This change does not affect the final binaries bugfix Fixes something that was expected to work differently backward-compatible labels Jul 19, 2024
@kim kim requested a review from Centril July 19, 2024 09:27
@bfops bfops added release-any To be landed in any release window and removed no runtime change This change does not affect the final binaries labels Jul 22, 2024
@bfops
Copy link
Collaborator

bfops commented Jul 22, 2024

I'm removing the no runtime change label since this is labeled as a bugfix 🧐 Am I crazy?

Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops!

@Centril Centril added this pull request to the merge queue Jul 29, 2024
Merged via the queue into master with commit 8508207 Jul 29, 2024
14 checks passed
@Centril Centril deleted the kim/fix/mut-schema-clone-on-write branch July 29, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-compatible bugfix Fixes something that was expected to work differently release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants