Ignore some sequence allocation mismatches when checking for compatible updates #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for schema compatibility before an update, we erroneously considered sequence allocations to be an incompatible change. This means that any module which contained at least one sequence/`autoinc` column which had allocated more than 4096 values would be impossible to ever update. With this change, we permit updates where the proposed sequence allocation is less than the known sequence allocation, and use the larger known sequence allocation as the value. This makes it possible to update modules which contain `autoinc` columns that have allocated more than 4096 values.
gefjon
force-pushed
the
phoebe/update-merge-sequence-allocated
branch
from
fb83e8f to
b641960
Compare
gefjon
changed the title
jdetter
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When checking for schema compatibility before an update, we erroneously considered sequence allocations to be an incompatible change. This means that any module which contained at least one sequence/
autoinccolumn which had allocated more than 4096 values would be impossible to ever update.With this change, we permit updates where the proposed sequence allocation is less than the known sequence allocation, and use the larger known sequence allocation as the value. This makes it possible to update modules which contain
autoinccolumns that have allocated more than 4096 values.API and ABI breaking changes
N/a.
Expected complexity level and risk
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!