CI - SpacetimeDB PRs run the C# SDK tests #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 12, 2024 13:57
bfops
added
release-any
jdetter
approved these changes
Jul 15, 2024
| - name: Create /stdb dir | ||
| run: | | ||
| sudo mkdir /stdb | ||
| sudo chmod 777 /stdb |
| ( cd crates/bindings-csharp/BSATN.Runtime && dotnet pack ) | ||
| cd spacetimedb-csharp-sdk | ||
|
|
||
| cat >nuget.config <<EOF |
There was a problem hiding this comment.
can we throw a comment on this explaining what we're doing here?
There was a problem hiding this comment.
added one - how does this look?
|
(did a final round of testing by manually downgrading the local package versions to match the NuGet versions, see the |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added a CI step that checks out
spacetimedb-csharp-sdkand runs its test suite.In the current PR incarnation, if the local major/minor package versions are bumped, the C# SDK tests will continue to use the old ones. This is because the C# SDK repo will still have its version numbers pointed to e.g.
0.10.*rather than e.g.0.11.*. Is this a bug or a feature?I kind of think that the current behavior is correct - if we bump the major/minor version numbers, we're explicitly aware that we're releasing a breaking change. This effectively tests the experience of a current user of the C# SDK (on
master). In that case, we can make this a required check.On the other hand, if we decide we want the C# SDK to always use the local versions, then this should not be made a required check. We may sometimes release breaking changes, which will need to happen in this repository before they happen in that one.
API and ABI breaking changes
No
Expected complexity level and risk
2
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
dotnet testis, in fact, runningbindings-csharpversions to 0.10.1 (to match the latest version on NuGet), the tests use the local versions (and fail, because the C# SDK repo is not yet updated for the latest packages)