Moving recovery code APIs under /identity and using POST #1492
Conversation
| axum::Router::new() | ||
| .route("/request_recovery_code", post(request_recovery_code::<S>)) | ||
| .route("/confirm_recovery_code", post(confirm_recovery_code::<S>)) | ||
| } |
There was a problem hiding this comment.
why is this a separate Router rather than just being part of the existing one?
There was a problem hiding this comment.
Was following the pattern of database's control/worker routes, but yeah merging them has the same effect.
There was a problem hiding this comment.
Yeah I think this merging makes sense, thank you. I did a bit of investigating and it seems like even in database.rs the distinction isn't important anymore.
|
@lcodes It looks like the smoketests are failing, but I don't think it has anything to do with this PR - can you update with latest Unfortunately, I don't think there's a way to test this recovery flow locally, so we'll have to merge and test it once deployed that has SendGrid enabled. |
lcodes
force-pushed
the
jeremie/api-stability/recovery-codes
branch
from
27434b5 to
6bc2019
Compare
bfops
force-pushed
the
jeremie/api-stability/recovery-codes
branch
from
b944987 to
906b2ec
Compare
Description of Changes
#1372
Added
control_routesto identity, based off database's.Moved the recovery code APIs there.
Switched them to expect POST.
API and ABI breaking changes
Changes both the request method and the router endpoints of the recovery code API.
Expected complexity level and risk
0
Testing
Assuming the previous handler code is correct, this validates the routes and request method switches.