Return empty success from /identity GET #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
reviewed
Jul 10, 2024
| @@ -77,7 +77,7 @@ pub async fn get_identity<S: ControlStateDelegate>( | |||
| (!identities.is_empty()).then_some(GetIdentityResponse { identities }) | |||
| } | |||
| }; | |||
| let identity_response = lookup.ok_or(StatusCode::NOT_FOUND)?; | |||
| let identity_response = lookup.unwrap_or_default(); | |||
There was a problem hiding this comment.
nit: it seems like we should still return an error (maybe 400 / Bad Request) if no email is provided at all?
lcodes
force-pushed
the
jeremie/identity-empty-success
branch
from
cddc396 to
4d3cfa9
Compare
bfops
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
#1371
Swap out the previous 404 for a default response.
API and ABI breaking changes
Changes the behavior in case of an empty email match, going from a client error to an empty success for its response.
Expected complexity level and risk
0
Testing