CLI: Use --server and --identity args consistently instead of anonymous args
#1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 8, 2024 10:58
…-cli-params' into bfops/ping-param
…-cli-params' into bfops/ping-param
bfops
changed the title
spacetime server subcommands use explicit --server/-s param--server and --identity params consistently
|
Looks good in principle; I'll let @jdetter approve though. |
added 2 commits
July 9, 2024 10:04
joshua-spacetime
approved these changes
Jul 10, 2024
jdetter
approved these changes
Jul 10, 2024
bfops
commented
Jul 10, 2024
bfops
changed the title
--server and --identity params consistently--server and --identity args consistently instead of anonymous args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updates the CLI's
energy,identity,list, andserversubcommands to consistently use--server/-sfor a server arg and--identity/-ifor an identity arg.All the subcommands altered by this PR used to use anonymous args for these.
Closes #1486.
API and ABI breaking changes
This breaks the CLI API for all altered subcommands!
This may necessitate updates to scripts that use the CLI... but it's hard to figure out which ones until they break 🥲
Expected complexity level and risk
1
Testing